Skip to content

Stop FindHeaderSection spinning forever on a file with no header #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starseeker merged 1 commit into from
Sep 10, 2026
Merged

Stop FindHeaderSection spinning forever on a file with no header #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/cleditor/STEPfile.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,15 @@ int STEPfile::FindHeaderSection( istream & in ) {
return 0;
}
in.getline( buf, BUFSIZ, ';' ); // reads but does not store the ;
if( in.fail() ) {
// A file with no ';' in its first BUFSIZ bytes - a binary file that
// is not STEP at all, say - sets failbit and leaves buf unchanged.
// eof() then never becomes true and the loop above spins forever.
_error.AppendToUserMsg(
"Error: Unable to find HEADER section. File not read.\n" );
_error.GreaterSeverity( SEVERITY_INPUT_ERROR );
return 0;
}
}
return 1;
}
Expand Down
Loading