fix: support sha256 zero object ids in pre-push hooks - #3761
Closed
chen-maker999 wants to merge 1 commit into
Closed
chen-maker999 wants to merge 1 commit into
chen-maker999 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3664.
hook_implused a 40-character zero object ID to detect deleted refs duringpre-push. Git emits 64-character zero IDs in SHA-256 repositories, so deleting a branch could fall through to an invalid revision range and reject the push.The new helper recognizes zero IDs for both supported object formats. The regression test exercises both 40-character and 64-character deletion records.
Tests:
python -m pytest tests/commands/hook_impl_test.py -q -k "new_branch or deleting_branch"(4 passed)pre-commit run --files pre_commit/commands/hook_impl.py tests/commands/hook_impl_test.py(formatting, imports, pyupgrade, autopep8, and flake8 passed; mypy reports existing baseline errors in unrelated files)hook_impl_test.pyrun has 44 passing tests and one existing Windows-specific legacy-script failure unrelated to this change.