Improve build performance - #105
Merged
mathiasbynens merged 1 commit intoSep 10, 2026
Merged
Conversation
Collaborator
|
LGTM but I’ll wait for the rebase. I do prefer the way to code looks with |
19.99s → 12.87s
JLHwung
force-pushed
the
improve-build-performance
branch
from
September 10, 2026 12:30
f9b4f6d to
647ebc3
Compare
Contributor
Author
|
Rebased. CPU profile shows that 80% of the running time is spent on the Compared with two years ago, the running time has increased from 10s to 14s, probably due to the |
Collaborator
|
Thanks! |
helmize1978
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes commits from #104, please review that PR first. I will rebase once that PR gets merged.
In abf6544 we have replaced sync fs I/O with sequential async fs I/O, which is less efficient because of the async overhead.
In this PR we reverted the async fs I/O changes and as we can see the build time has been improved from 20s to 14s, a 1.4x performance gain.
Runtime measured in my local environment (Apple M1 Max 10c)