fix: keep the URL's query string when params are passed - #145
Merged
Merged
Conversation
httpx2 replaces a URL's query whenever params are sent, including client-level params (pydantic/httpx2#905). Fold the URL query into params in build_request, the per-verb methods and stream, for both clients. Precedence: client params < URL query < per-request params.
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A URL's own query string was silently dropped whenever params were sent:
get("/items?a=1", params={"b": "2"})?b=2?a=1&b=2get("/items?a=1&b=1", params={"b": "2"})?b=2?a=1&b=2params={"c": "3"},get("/items?a=1")?c=3?c=3&a=1get("/items?a=1", params={})?a=1The cause is upstream:
httpx2.URL(url, params=...)replaces the query rather than merging, andhttpx2.Client._merge_queryparamsmerges only client and request params. httpware passedparamsstraight through.Upstream status: pydantic/httpx2#905 is open, and fix PR pydantic/httpx2#966 has been open since 2026-05 without review. The original httpx maintainer treated the replace behaviour as intended (encode/httpx#3433). If #966 lands, this change still yields the same URL and the helper can be removed.
Fix
_merge_url_queryfolds the URL's query intoparamsbefore handing off to httpx2. It is applied inbuild_request, the per-verb methods (_prepare_request) andstream, on bothClientandAsyncClient.params; the per-request value wins on the same key.?a=1&a=2) are kept.nextkeep their original encoding.Behaviour change
paramsreplacing the URL's query now gets a merge.+may become%20); semantically equivalent.base_urlis still dropped by httpx2's_merge_url.Tests
tests/test_url_query_merge.py: 44 cases acrossbuild_request,getandstreamfor both clients, written first (37 failed before the fix). Full suite, ruff, ty and eof-fixer pass locally.