refactor: delete the unreachable None branch in retry-after parsing - #141
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Delete the
if parsed is None: return Nonebranch (and its# pragma: no cover) in_parse_retry_after,src/httpware/middleware/resilience/retry.py.Why
email.utils.parsedate_to_datetimecannot returnNoneon any interpreter httpware supports (requires-python >=3.11), so the branch was dead code that coverage had to be told to ignore.Evidence
inspect.getsourceon 3.11.16, 3.12.13, 3.13.15, 3.14.7): the function has exactly tworeturnstatements, and both return adatetime.datetime(...). When_parsedate_tzyieldsNoneit doesraise ValueError('Invalid date value or format ...'). 3.13+ also turnsOverflowErrorfrom thedatetimeconstructor intoValueError.email.utils): the function "on success returns adatetime; otherwiseValueErroris raised"."","garbage", day 32, a bad month, hour 25, NUL, a huge year, a missing or unknown zone,-0000). Every call either raised or returned adatetime, and none returnedNone.Checks (local)
just install: no lockfile changejust lint-ci: passjust test-ci: 819 passed, coverage 100.00%