feat: route GET/HEAD requests to an optional read replica - #71
Merged
Merged
Conversation
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30.
What
DB_REPLICA_DSNsetting (default empty). When set,GET/HEADrequests use a replica engine; every other method, and any resolution without a request, uses the primary. When unset, behaviour is unchanged and no second pool is created.app/ioc.py:database_engine(primary),database_replica_engine(AsyncEngine | None), and a request-scopeddynamic_enginechosen bychoose_sa_engine. The session getsdynamic_enginevia explicit kwargs.dynamic_enginewith the rolled-back connection, so reads and writes still share one transaction.tests/test_db_routing.pycovers method routing, no-request fallback, no-replica fallback, and building the replica engine from the DSN.Design notes
chatsservice, with two deliberate differences:dynamic_engineexplicitly instead of relying onbound_type=Nonemaking it the onlyAsyncEnginefor type autowiring. Both base engines arebound_type=Noneso modern-di does not raise a duplicate-type error.DB_REPLICA_DSNinstead of adb-retrymulti-host DSN withtarget_session_attrs. It keeps the template dependency-free and the config obvious;db-retryalso requires a separate database name.Nonerather than aliasing the primary provider, so the routing is testable by overriding each engine independently.HEADgoes to the replica alongsideGET, since it is equally read-only.app/resources/*.pyis exempted from ruff'sTCrules: modern-di evaluates creator annotations at runtime, and ruff's autofix movingimport fastapiunderTYPE_CHECKINGbroke resolution withNameError.Caveats