Skip to content

MNT: drop unused pre-commit (the package) dependency - #32407

Merged
greglucas merged 1 commit into
matplotlib:mainfrom
tacaswell:mnt/drop_precommit
Sep 28, 2026
Merged

greglucas merged 1 commit into
matplotlib:mainfrom
tacaswell:mnt/drop_precommit

Conversation

@tacaswell

Copy link
Copy Markdown
Member

PR summary

We have moved to prek but this got missed in the migration. This PR:

  • changes the depnedency in pyproject.toml to prek (matches our docs and CI runs)
  • clarified a title that "pre-commit" means "git's pre-commit" not "pre-commit the confusingly named project that provides pre-commit hooks".
  • adjusts the in-line install suggestion to pixi or uv's global tool invocations (things can break in weird ways if you install prek from a virtual env that you later clean up)

AI Disclosure

None

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • [/] New and changed code is tested
  • [/] Plotting related features are demonstrated in an example
  • [/] New features and API changes have release notes
  • Documentation complies with general and docstring guidelines

We have moved to prek but this got missed in the migration.
@tacaswell tacaswell added this to the v3.12.0 milestone Sep 28, 2026
@github-actions github-actions Bot added CI: Run cibuildwheel Run wheel building tests on a PR Documentation: devdocs files in doc/devel labels Sep 28, 2026
@greglucas
greglucas merged commit 50b2560 into matplotlib:main Sep 28, 2026
39 of 41 checks passed
@tacaswell
tacaswell deleted the mnt/drop_precommit branch September 28, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Run cibuildwheel Run wheel building tests on a PR Documentation: devdocs files in doc/devel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants