Raise ImportError when cairocffi cannot load cairo - #32400
Merged
Merged
Conversation
iccir
commented
Sep 26, 2026
iccir
force-pushed
the
catch-oserror
branch
from
September 26, 2026 17:46
be18e70 to
71b9061
Compare
greglucas
reviewed
Sep 28, 2026
Co-authored-by: Greg Lucas <[email protected]>
greglucas
approved these changes
Sep 28, 2026
ayshih
approved these changes
Sep 28, 2026
Contributor
|
@meeseeksdev backport to v3.11.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
On macOS, trying to run
pytestwith cairocffi installed but no cairo produces an OSError fromdlopen():Originally, I added OSError to test_backends_rendering.py to fix this.
However, I decided that it would be better to catch the
OSErrorin backend_cairo.py and then re-throw as anImportErrorwith a better error message.AI Disclosure
None used.
PR quality check