This repository was archived by the owner on Mar 9, 2026. It is now read-only.
feat(pubsub): implement max_duration_per_lease_extension option - #38
Merged
Conversation
IlyaFaer
added
the
type: feature request
googlebot
added
the
cla: yes
IlyaFaer
changed the title
IlyaFaer
commented
Feb 26, 2020
IlyaFaer
marked this pull request as ready for review
February 26, 2020 10:45
pradn
reviewed
Feb 28, 2020
Contributor
|
It looks pretty good, just a small comment. Let's wait on merging this in until we have word on the final name for "max_extension_period". |
added 2 commits
March 2, 2020 12:45
IlyaFaer
changed the title
pradn
reviewed
Mar 2, 2020
pradn
reviewed
Mar 2, 2020
pradn
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35