Skip to content

Optimize non buffered protocol reads in SSLProtocol #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tarasko wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Optimize non buffered protocol reads in SSLProtocol #726

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
33d0ea4
WIP
Jan 31, 2026
5385ebe
Cleanup
Jan 31, 2026
58ce0be
Fix memory leak in SSLProtocol and test_create_connection_memory_leak…
Jan 31, 2026
d33c852
Add some comments
Jan 31, 2026
649f8de
Optimize and cleanup _do_read_into_void
Jan 31, 2026
1345960
Fix bytearray allocation
Jan 31, 2026
3e1a8a8
Format code
Jan 31, 2026
64ff06e
Cleanup for PR
Feb 1, 2026
cde915d
Cleanup cython imports
Feb 1, 2026
6f91a52
Better name for variable
Feb 8, 2026
7e66d06
Merge branch 'master' into optimize_ssl_nonbuffered_read
tarasko Apr 28, 2026
b771722
Merge branch 'master' into optimize_ssl_nonbuffered_read
fantix May 1, 2026
d3e0314
Merge branch 'master' into optimize_ssl_nonbuffered_read
tarasko Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix memory leak in SSLProtocol and test_create_connection_memory_leak… 
… test
  • Loading branch information
taras
taras committed Jan 31, 2026
commit 58ce0be749305958bfe743236c401a577cba53f2
5 changes: 5 additions & 0 deletions uvloop/sslproto.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ cdef class SSLProtocol:
self._transport = None
self._app_transport = None
self._app_protocol = None
self._app_protocol_get_buffer = None
self._app_protocol_data_received = None
self._app_protocol_buffer_updated = None
self._wakeup_waiter(exc)

if self._shutdown_timeout_handle:
Expand Down Expand Up @@ -860,6 +863,8 @@ cdef class SSLProtocol:
elif first_chunk is not None:
self._app_protocol_data_received(first_chunk)

# SSLObject.read() may return 0 instead of throwing SSLWantReadError
# This indicates that we reached EOF
if bytes_read == 0:
# close_notify
self._call_eof_received()
Expand Down
Loading