Skip to content

Add input-aware AST signatures#4376

Merged
andimarek merged 2 commits into
masterfrom
ast-signature-with-input
May 9, 2026
Merged

Add input-aware AST signatures#4376
andimarek merged 2 commits into
masterfrom
ast-signature-with-input

Conversation

@andimarek
Copy link
Copy Markdown
Member

@andimarek andimarek commented May 9, 2026

Summary

  • add AstSignature.signatureWithInput(Document, @Nullable String, GraphQLSchema, CoercedVariables)
  • preserve supplied argument and input object field shapes while redacting concrete values
  • expand coerced variable values recursively and keep omitted arguments/input fields omitted
  • add focused Spock coverage for scalar redaction, variables, defaults, directives, fragments, and recursive inputs

Testing

  • ./gradlew test --tests graphql.language.AstSignatureTest
  • git diff --check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026 •
edited
Loading

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5762 (+29 🟢) 5706 (+29 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5762 (+29 🟢) 5705 (+29 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5762 (+29 🟢) 5705 (+29 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5762 (+29 🟢) 5705 (+29 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23080 (+116 🟢) 22853 (+116 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 29169 3113 90.4% +0.1% 🟢
Branches 8558 1508 85.0% +0.2% 🟢
Methods 7791 1218 86.5% +0.1% 🟢

Changed Class Coverage (3 classes)

Class Line Branch Method
g.l.AstSignature ±0.0% +13.3% 🟢 ±0.0%
g.l.FragmentSpread +6.5% 🟢 ±0.0% +11.1% 🟢
g.l.VariableDefinition +7.3% 🟢 ±0.0% +8.7% 🟢

Full HTML report: build artifact jacoco-html-report

Updated: 2026-05-09 22:22:16 UTC

@andimarek andimarek enabled auto-merge (squash) May 9, 2026 22:13
@andimarek andimarek merged commit 42e73c2 into master May 9, 2026
11 checks passed
@andimarek andimarek mentioned this pull request May 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andimarek