Skip to content

Avoid no-op field fetch adapter allocation #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nwjsmith wants to merge 1 commit into
base: master
Choose a base branch
from
+75 −0
Open

Avoid no-op field fetch adapter allocation #4375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/graphql/execution/instrumentation/Instrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ default InstrumentationContext<Object> beginFieldFetch(InstrumentationFieldFetch
@Nullable
default FieldFetchingInstrumentationContext beginFieldFetching(InstrumentationFieldFetchParameters parameters, InstrumentationState state) {
InstrumentationContext<Object> ctx = beginFieldFetch(parameters, state);
if (ctx == noOp()) {
return FieldFetchingInstrumentationContext.NOOP;
}
return FieldFetchingInstrumentationContext.adapter(ctx);
}

Expand Down
72 changes: 72 additions & 0 deletions src/test/groovy/graphql/execution/instrumentation/InstrumentationDefaultMethodsTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package graphql.execution.instrumentation

import graphql.execution.instrumentation.parameters.InstrumentationFieldFetchParameters
import spock.lang.Specification

class InstrumentationDefaultMethodsTest extends Specification {

def "default begin field fetching does not allocate an adapter for inherited no-op"() {
given:
def instrumentation = new Instrumentation() {}

when:
def context = instrumentation.beginFieldFetching(null, null)

then:
context.is(FieldFetchingInstrumentationContext.NOOP)
}

def "simple performant instrumentation begin field fetching does not allocate an adapter for inherited no-op"() {
when:
def context = SimplePerformantInstrumentation.INSTANCE.beginFieldFetching(null, null)

then:
context.is(FieldFetchingInstrumentationContext.NOOP)
}

def "default begin field fetching does not allocate an adapter when deprecated override returns no-op"() {
given:
def instrumentation = new Instrumentation() {
@Override
InstrumentationContext<Object> beginFieldFetch(InstrumentationFieldFetchParameters parameters, InstrumentationState state) {
return SimpleInstrumentationContext.noOp()
}
}

when:
def context = instrumentation.beginFieldFetching(null, null)

then:
context.is(FieldFetchingInstrumentationContext.NOOP)
}

def "default begin field fetching still adapts deprecated begin field fetch overrides"() {
given:
def events = []
def instrumentation = new Instrumentation() {
@Override
InstrumentationContext<Object> beginFieldFetch(InstrumentationFieldFetchParameters parameters, InstrumentationState state) {
return new InstrumentationContext<Object>() {
@Override
void onDispatched() {
events.add("dispatched")
}

@Override
void onCompleted(Object result, Throwable t) {
events.add(result)
}
}
}
}

when:
def context = instrumentation.beginFieldFetching(null, null)
context.onDispatched()
context.onFetchedValue("ignored")
context.onCompleted("completed", null)

then:
events == ["dispatched", "completed"]
}
}