Skip to content

Now does not overwrite a types default data fetcher unless its nonnull#3579

Merged
bbakerman merged 2 commits into
masterfrom
dont-overwrite-default-data-fetchers-if-they-are-null
May 21, 2024
Merged

Now does not overwrite a types default data fetcher unless its nonnull#3579
bbakerman merged 2 commits into
masterfrom
dont-overwrite-default-data-fetchers-if-they-are-null

Conversation

@bbakerman
Copy link
Copy Markdown
Member

See #3431 for more detail on the problem fixed

unless its nonnull

See # 3431
public Map<String, DataFetcher> getDataFetchersForType(String typeName) {
return dataFetchers.computeIfAbsent(typeName, k -> new LinkedHashMap<>());
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Comment thread src/test/groovy/graphql/schema/idl/RuntimeWiringTest.groovy Outdated
@bbakerman bbakerman added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit 53f22c5 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants