Removed deprecated methods from fields / unions and interfaces#3513
Closed
bbakerman wants to merge 2 commits into
Closed
Removed deprecated methods from fields / unions and interfaces#3513bbakerman wants to merge 2 commits into
bbakerman wants to merge 2 commits into
Conversation
Member
Author
|
Ahh boo - I think I started this PR off the code in #3512 |
dondonz
approved these changes
Mar 11, 2024
Member
Author
|
We are not going to remove the DataFetches on fields and type resolvers on types The risk rewards is not there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finally removes the ability to specify code on type objects. You can not longer put a DataFetcher on a field or a type resolve on the Union / Interface
You must use
GraphQLCodeRegistrynow for this. This has deprecation been in place for 5 years - its time!