Skip to content

Does not allocate a default deferred context that is thrown away on transform #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Mar 4, 2024
Merged

Does not allocate a default deferred context that is thrown away on transform #3484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/graphql/execution/ExecutionStrategyParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public static class Builder {
ResultPath path = ResultPath.rootPath();
Copy link
Copy Markdown
Member Author

@bbakerman bbakerman Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root is a constant so its cheap as a default

MergedField currentField;
ExecutionStrategyParameters parent;
DeferredCallContext deferredCallContext = new DeferredCallContext();
DeferredCallContext deferredCallContext;

/**
* @see ExecutionStrategyParameters#newParameters()
Expand Down Expand Up @@ -188,6 +188,9 @@ public Builder deferredCallContext(DeferredCallContext deferredCallContext) {
}

public ExecutionStrategyParameters build() {
if (deferredCallContext == null) {
deferredCallContext = new DeferredCallContext();
}
return new ExecutionStrategyParameters(executionStepInfo, source, localContext, fields, nonNullableFieldValidator, path, currentField, parent, deferredCallContext);
}
}
Expand Down