Skip to content

Adding in Java 9+ support for lookup across class loaders #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
May 17, 2023
Merged

Adding in Java 9+ support for lookup across class loaders #3219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/main/java/graphql/schema/fetching/LambdaFetchingSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,16 @@ static Function<Object, Object> mkCallFunction(Class<?> targetClass, String targ
return getterFunction;
}

private static MethodHandles.Lookup getLookup(Class<?> targetClass) throws IllegalAccessException {
private static MethodHandles.Lookup getLookup(Class<?> targetClass) {
MethodHandles.Lookup lookupMe = MethodHandles.lookup();
//
// This is a Java 9 approach to method look up allowing private access
// which we don't want to use yet until we get to Java 11
// This is a Java 9+ approach to method look up allowing private access
//
//lookupMe = MethodHandles.privateLookupIn(targetClass, lookupMe);
return lookupMe;
try {
return MethodHandles.privateLookupIn(targetClass, lookupMe);
} catch (IllegalAccessException e) {
return lookupMe;
}
}

}
13 changes: 5 additions & 8 deletions src/test/groovy/graphql/schema/fetching/LambdaFetchingSupportTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,18 +182,15 @@ class LambdaFetchingSupportTest extends Specification {
def getter = LambdaFetchingSupport.createGetter(customClass, "hello")
then:

// with Java 9+ we can get access to methods across class loaders
getter.isPresent()
try {
getter.get().apply(targetObject)
assert false, "We expect this to fail on Java 8 without access to MethodHandles.privateLookupIn"
} catch (LinkageError | ClassCastException ignored) {
}
def value = getter.get().apply(targetObject)
value == "world"

// show that a DF can still be used access this because of the reflection fallback
// in the future it will work via MethodHandles.privateLookupIn
// show that a DF can be used
when:
def ageDF = PropertyDataFetcher.fetching("hello")
def value = ageDF.get(fld("hello"), targetObject, { -> null })
value = ageDF.get(fld("hello"), targetObject, { -> null })
then:
value == "world"
}
Expand Down