Conversation
JeanMeche
force-pushed
the
forms/refactor-obs
branch
from
April 8, 2024 22:09
39167ab to
aed0954
Compare
JeanMeche
force-pushed
the
forms/refactor-obs
branch
2 times, most recently
from
April 8, 2024 23:43
d690fc5 to
bd61116
Compare
This is a refactoring on top of angular#54579 which we weren't able to land because it had breakages in G3 : explicit calls to `emit` on the observables. Should also fix angular#54418
JeanMeche
force-pushed
the
forms/refactor-obs
branch
from
April 22, 2024 15:56
bd61116 to
50cad9f
Compare
|
Is this PR going to make it to the initial v18 release? Really looking forward to the new events behaviour for abstract controls. This is going to make custom controls for me to be so much cleaner. |
Member
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring on top of #54579 which we weren't able to land because it had breakages in G3 : explicit calls to
emiton the observables.Should also fix #54418
Edit: example for breakage mentionned here.
cc @dylhunn