Skip to content

Adding @actions/exec to github-script#178

Merged
joshmgross merged 8 commits into
actions:mainfrom
bhavanakonchada:bhavanakonchada-exec
Aug 19, 2021
Merged

Adding @actions/exec to github-script#178
joshmgross merged 8 commits into
actions:mainfrom
bhavanakonchada:bhavanakonchada-exec

Conversation

@bhavanakonchada

Copy link
Copy Markdown

The @actions/exec package is useful to execute tools in a cross platform way. This package is now available to the script using the exec variable.

@bhavanakonchada
bhavanakonchada requested a review from a team August 11, 2021 20:57

@joshmgross joshmgross left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey, thanks for this contribution. It looks like a large change was made to package-lock.json switching from lockfileVersion 2 to 1 - https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#lockfileversion

Since we're already on a newer version, I'd prefer not go back to version 1. Could you update your version of npm and re-run npm install?

I'd be happy to help with that change if you'd like.

@bhavanakonchada

Copy link
Copy Markdown
Author

👋 Hey, thanks for this contribution. It looks like a large change was made to package-lock.json switching from lockfileVersion 2 to 1 - https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#lockfileversion

Since we're already on a newer version, I'd prefer not go back to version 1. Could you update your version of npm and re-run npm install?

I'd be happy to help with that change if you'd like.

@joshmgross thanks so much for taking a keen look at the PR, updated npm as you suggested to ensure package-lock.json is now at version 2.

@bhavanakonchada

Copy link
Copy Markdown
Author

Hi @joshmgross , do you believe this PR can be merged, after the checks passing and incorporating feedback ?

@joshmgross
joshmgross merged commit e02270e into actions:main Aug 19, 2021
@joshmgross

Copy link
Copy Markdown
Contributor

👋 Hey @bhavanakonchada, thanks for your contribution!

This is now available in https://github.com/actions/github-script/releases/tag/v4.1.0, which can be accessed with the following refs in your workflow:

  • main
  • v4.1.0
  • v4.1
  • v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants