Skip to content

Javascript_shuffle_issue_fixed#1898

Open
KrishnaVipul14 wants to merge 1 commit into
TheAlgorithms:masterfrom
KrishnaVipul14:master
Open

Javascript_shuffle_issue_fixed#1898
KrishnaVipul14 wants to merge 1 commit into
TheAlgorithms:masterfrom
KrishnaVipul14:master

Conversation

@KrishnaVipul14
Copy link
Copy Markdown

@KrishnaVipul14 KrishnaVipul14 commented May 16, 2026 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@KrishnaVipul14 KrishnaVipul14 requested a review from appgurueu as a code owner May 16, 2026 18:13
@KrishnaVipul14
Copy link
Copy Markdown
Author

KrishnaVipul14 commented May 16, 2026

Fixed the shuffle implementation used in bogoSort by replacing the biased random index selection with the standard unbiased Fisher–Yates algorithm. The updated logic now selects indices from the inclusive range [0, i], ensuring all permutations are equally likely and reachable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KrishnaVipul14