Fix missing space when AtRule#params is set after parsing - #2113
Merged
Merged
Conversation
Member
|
Thanks. Released in 8.5.20. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
AtRule#paramson an at-rule that was parsed without params glues the params onto the name:@layerutilitiesis a single at-word, so the output no longer parses back to the at-rule that produced it. Same for@media{},@scope{},@font-face{}— anything written without params.atruleStart()already has a fallback that inserts the space whenraws.afterNameis missing, but the parser setsraws.afterName = ''explicitly for a params-less at-rule, so the fallback never gets a chance to run.I still prefer the raw when it's there, and only fall back to a space when the params would otherwise merge into the at-rule name token.
@media(min-width:0)and@import"a.css"stay byte-identical:(and"end the at-word on their own, and those delimiters are the only way the parser can produce an emptyafterNametogether with non-empty params.Found this fuzzing mutation round-trips over the postcss-parser-tests fixtures — across ~10k parse → set params → re-parse cases this was the only invariant that broke (100 distinct failures before, 0 after). Added tests for both directions;
pnpm testis green.