make assigning property via reference impure#3082
Merged
Merged
Conversation
schlndh
force-pushed
the
feature-impureAssignRef
branch
from
May 17, 2024 12:28
1f01c4c to
c2bb307
Compare
ondrejmirtes
requested changes
May 18, 2024
ondrejmirtes
requested changes
May 18, 2024
ondrejmirtes
requested changes
May 30, 2024
| $expr, | ||
| 'propertyAssignByRef', | ||
| 'property assignment by reference', | ||
| false, |
Member
There was a problem hiding this comment.
Should be true, right? There isn't a case where this might still be pure.
Contributor
Author
There was a problem hiding this comment.
It could be pure:
I set certain = false, because theoretically the referenced variable may already be set, and the reference may never be written. In which case it would be pure. But I can't imagine why the reference would be used in such a way in the first place.
<?php
class Foo
{
public ?int $foo;
public function bar(): void
{
$x = &$this->foo;
}
}
$foo = new Foo;
$foo->foo = 5;
$foo->bar();
var_dump($foo->foo);
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://phpstan.org/r/cbe5c7f9-f5bd-4101-8cf6-37b7732946d4
I set
certain = false, because theoretically the referenced variable may already be set, and the reference may never be written. In which case it would be pure. But I can't imagine why the reference would be used in such a way in the first place.