Ensure http_response_header is a list<string>#2959
Merged
Conversation
Contributor
|
since no test is failling after the change it seems we are missing a NodeScopeResolverTest with a type inference assertion for this variable :) |
staabm
reviewed
Mar 8, 2024
Contributor
There was a problem hiding this comment.
ohh I think you are missing another assert for assertNativeType
Contributor
Author
There was a problem hiding this comment.
Ok hopefully I did this correctly :)
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if that's the proper/best use of AccessoryArrayListType, but anyway I hope the intent is clear :)