Array is non-empty when in_array is not strict#2539
Merged
Conversation
staabm
marked this pull request as ready for review
January 23, 2024 08:45
Collaborator
|
This pull request has been marked as ready for review. |
staabm
marked this pull request as draft
January 31, 2024 09:02
staabm
marked this pull request as ready for review
January 31, 2024 13:08
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
Author
|
@ondrejmirtes I think getting this merged would help a lot of non-strict codebases, because |
clxmstaab
force-pushed
the
bug9662
branch
2 times, most recently
from
May 15, 2024 11:29
3c01e04 to
b1d0623
Compare
Member
|
Thank you! |
ghost
mentioned this pull request
|
Hi, this PR does not close phpstan/phpstan#10228. Here I have the updated playground after your change https://phpstan.org/r/026707d1-2de9-4bbb-8f1c-d47312de414c. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements true-context type narrowing to non-empty-array for non-strict use of
in_array.with this PR we only narrow when
$needleis of the same type as the$haystack's iterable type.when non-strict, the loose-compare falsey context would be pretty complicated, therefore this PR just implements the true-context part (which already fixes 2 reported issues).
there is still room for improvement in true and false-context but this is a good first step which should already cover a lot of real-world code.
closes phpstan/phpstan#9662
closes phpstan/phpstan#10228