Skip to content

fix(alert): fix hover styles, HC borders #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 1 commit into from
Sep 9, 2025
Merged

fix(alert): fix hover styles, HC borders #7813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/patternfly/components/Alert/alert-group-overflow-button.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
<button class="{{pfv}}alert-group__overflow-button{{#if alert-group-overflow-button--modifier}} {{alert-group-overflow-button--modifier}}{{/if}}"
{{#if alert-group-overflow-button--attribute}}
{{{alert-group-overflow-button--attribute}}}
{{/if}}>
{{#if alert-group-overflow-button--text}}
{{{alert-group-overflow-button--text}}}
{{/if}}
{{#if @partial-block}}
{{> @partial-block}}
{{/if}}
</button>
<li>
<button class="{{pfv}}alert-group__overflow-button{{#if alert-group-overflow-button--modifier}} {{alert-group-overflow-button--modifier}}{{/if}}"
{{#if alert-group-overflow-button--attribute}}
{{{alert-group-overflow-button--attribute}}}
{{/if}}>
{{#if alert-group-overflow-button--text}}
{{{alert-group-overflow-button--text}}}
{{/if}}
{{#if @partial-block}}
{{> @partial-block}}
{{/if}}
</button>
</li>
24 changes: 6 additions & 18 deletions src/patternfly/components/Alert/alert-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
--#{$alert-group}--m-toast__item--m-offstage-right--c-alert--Transition: initial;

// Overflow button
--#{$alert-group}__overflow-button--BorderWidth: var(--pf-t--global--border--width--action--plain--default);
--#{$alert-group}__overflow-button--BorderWidth: var(--pf-t--global--border--width--high-contrast--regular);
--#{$alert-group}__overflow-button--BorderColor: var(--pf-t--global--border--color--high-contrast);
--#{$alert-group}__overflow-button--BorderRadius: var(--pf-t--global--border--radius--medium);
--#{$alert-group}__overflow-button--PaddingBlockStart: var(--pf-t--global--spacer--md);
Expand All @@ -100,9 +100,11 @@
--#{$alert-group}__overflow-button--Color: var(--pf-t--global--text--color--link--default);
--#{$alert-group}__overflow-button--BoxShadow: var(--pf-t--global--box-shadow--lg);
--#{$alert-group}__overflow-button--BackgroundColor: var(--pf-t--global--background--color--floating--default);
--#{$alert-group}__overflow-button--hover--BorderWidth: var(--pf-t--global--border--width--action--plain--hover);
--#{$alert-group}__overflow-button--hover--BorderWidth: var(--pf-t--global--border--width--high-contrast--strong);
--#{$alert-group}__overflow-button--hover--Color: var(--pf-t--global--text--color--link--hover);
--#{$alert-group}__overflow-button--hover--BackgroundColor: var(--pf-t--global--background--color--floating--hover);

// TODO - remove this block in breaking change, not used
--#{$alert-group}__overflow-button--hover--BoxShadow: var(--pf-t--global--box-shadow--lg), var(--pf-t--global--box-shadow--lg--bottom);
--#{$alert-group}__overflow-button--focus--Color: var(--pf-t--global--text--color--link--hover);
--#{$alert-group}__overflow-button--focus--BoxShadow: var(--pf-t--global--box-shadow--lg), var(--pf-t--global--box-shadow--lg--bottom);
Expand Down Expand Up @@ -152,6 +154,8 @@
&:hover,
&:focus {
--#{$alert-group}__overflow-button--BorderWidth: var(--#{$alert-group}__overflow-button--hover--BorderWidth);
--#{$alert-group}__overflow-button--BackgroundColor: var(--#{$alert-group}__overflow-button--hover--BackgroundColor);
--#{$alert-group}__overflow-button--Color: var(--#{$alert-group}__overflow-button--hover--Color);
}
}

Expand Down Expand Up @@ -278,20 +282,4 @@
}
}
}

&:hover {
--#{$alert-group}__overflow-button--Color: var(--#{$alert-group}__overflow-button--hover--Color);
--#{$alert-group}__overflow-button--BackgroundColor: var(--#{$alert-group}__overflow-button--hover--BackgroundColor);
--#{$alert-group}__overflow-button--BoxShadow: var(--#{$alert-group}__overflow-button--hover--BoxShadow);
}

&:focus {
--#{$alert-group}__overflow-button--Color: var(--#{$alert-group}__overflow-button--focus--Color);
--#{$alert-group}__overflow-button--BoxShadow: var(--#{$alert-group}__overflow-button--focus--BoxShadow);
}

&:active {
--#{$alert-group}__overflow-button--Color: var(--#{$alert-group}__overflow-button--active--Color);
--#{$alert-group}__overflow-button--BoxShadow: var(--#{$alert-group}__overflow-button--active--BoxShadow);
}
}
5 changes: 1 addition & 4 deletions src/patternfly/components/Alert/examples/Alert.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,7 @@ For sighted users, interactive elements can be included in this message in one o
{{/alert-action}}
{{/alert}}
{{/alert-item}}

{{#> alert-item}}
{{> alert-group-overflow-button alert-group-overflow-button--text="View 3 more notifications"}}
{{/alert-item}}
{{> alert-group-overflow-button alert-group-overflow-button--text="View 3 more notifications"}}
{{/alert-group}}
```

Expand Down