fix(alert): fix hover styles, HC borders - #7813
Merged
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7813.surge.sh A11y report: https://pf-pr-7813-a11y.surge.sh |
srambach
approved these changes
Sep 9, 2025
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.64 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes toward #7796
But I also noticed we had
:hover/focus/activestyles on the alert-group-item (an<li>that isn't interactive/focusable) instead of on the overflow button so I 1) removed those styles and 2) put the appropriate changes on the overflow button.Also in react, a plain ol'
<li>wraps the overflow button, not ali.pf-v6-c-alert-group__item, so the:hoverstyles I removed weren't working. That should be fixed with the changes above, but I also wrapped the overflow button in an<li>in the core docs to match react.