fix(drawer): add top border in high contrast - #7811
Conversation
|
Preview: https://pf-pr-7811.surge.sh A11y report: https://pf-pr-7811-a11y.surge.sh |
lboehling
left a comment
lboehling
left a comment
There was a problem hiding this comment.
i think this looks good! benefits of the border in the full height drawer outweigh the slight weirdness with the double border when it's in page. Wondering if there is anyway to just target the notification drawer specifically to add the top border? if not i think this is g2g!
|
@lboehling updated to just style the "notification drawer" drawer. Here are places you can see the "notification drawer" that should get the border
You should not see that border on any other drawer - like any of the drawer examples, the primary-detail drawers, etc Question - when the drawer width spans the width of the viewport (on mobile), do you still want the border? Here are some screenshots: Panel expanded on desktop
Panel expanded on mobile (with border)
Panel expanded on mobile (without border)
Drawer collapsed on mobile
|
|
this all looks awesome thank you @mcoker! Yes, i think we should have the border on mobile too. thanks! |
|
🎉 This PR is included in version 6.3.0-prerelease.70 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
@lboehling this adds a top border to all drawer panels. This would mean there would be a double border with the panel open if there were already a top border added in the UI, but I wonder if that's worth the trade-off of this adding a border to places there is not currently a border between the drawer and whatever is above it (like the notification drawer)Adds a top border to drawer panels when the HTML structure is attached to the page layout - most common use of this layout is with a notification drawer. This is also the HTML structure generated when using
<Page notificationDrawer={...} />fixes #7805