Skip to content

chore(backstop): update visual regression tests - #7757

Merged
mcoker merged 1 commit into
patternfly:mainfrom
srambach:update-screen-captures
Aug 25, 2025
Merged

mcoker merged 1 commit into
patternfly:mainfrom
srambach:update-screen-captures

Conversation

@srambach

Copy link
Copy Markdown
Member

Updates visual regression test. Report includes a couple of inline edit examples that seem to be a glitch because I re-ran the test and it corrected.

https://drive.google.com/file/d/1Tcdh_F99TxdtchkDXOSUu0jXd80dSaNI/view?usp=sharing

One problem noted

  • Text overflows container at mobile width in /components/expandable-section/html/disclosure-variation-indented/ text overflows

Changes noticed and expected:

  • Wizard - nav spacing
  • Wizard - warning step
  • Text input group - placeholder disabled color
  • Text input group - new example
  • Text input group with navigable options
  • Sortable table - header vertical alignment
  • Expandable table - vertical alignment of caret
  • Label group close button color
  • Vertical label group width because of change of button from no padding to small
  • Inline edit state invalid - buttons missing - but reappeared in subsequent run
  • Error helper text example added
  • Expandable section example text change
  • Toolbar with validation demo - error icon
  • Ghost line reappeared on mobile views
  • Expected spinner diffs

@patternfly-build

patternfly-build commented Aug 25, 2025 •

Copy link
Copy Markdown
Collaborator

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Thank you @srambach!

Text overflows container at mobile width in /components/expandable-section/html/disclosure-variation-indented/ text overflows

IMO that's OK, we just added more text to that button. I imagine we have a handful of examples that would do that on a very narrow screen.

@mcoker
mcoker merged commit 91c8d29 into patternfly:main Aug 25, 2025
4 checks passed
@patternfly-build

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.3.0-prerelease.51 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants