Skip to content

feat(DataList): remove li aria, update ids #7748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatblindgeye merged 4 commits into from
Aug 28, 2025
Merged

feat(DataList): remove li aria, update ids #7748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ec9ac3
feat(DataList): remove li aria, update ids
kmcfaul Aug 19, 2025
64ec847
fix(DataList): remove extra hyphen
kmcfaul Aug 25, 2025
8589dad
fix(DataList): fix arialabelledby ids
kmcfaul Aug 28, 2025
61ed3bd
feat(DataList): update expandable fullpage demo
kmcfaul Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/patternfly/components/DataList/data-list-item.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
{{#if data-list-item--expanded}} pf-m-expanded{{/if}}
{{#if data-list-item--IsClickable}} pf-m-clickable{{/if}}
{{#if data-list-item--IsSelected}} pf-m-selected{{/if}}"
aria-labelledby="{{data-list--id}}-{{data-list-item--id}}"
{{#if data-list-item--IsClickable}}
tabindex="0"
{{/if}}
Expand Down
34 changes: 17 additions & 17 deletions src/patternfly/components/DataList/examples/DataList.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-1" data-list-item--expanded="true"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item-1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell data-list-cell--modifier="pf-m-icon"}}
Expand Down Expand Up @@ -238,7 +238,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-2"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item-2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand All @@ -263,7 +263,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--expanded="true" data-list-item--id="item-3"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item-3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell data-list-cell--modifier="pf-m-icon"}}
Expand Down Expand Up @@ -296,7 +296,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--expanded="true" data-list-item--id="item-1"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item-1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell data-list-cell--modifier="pf-m-icon"}}
Expand Down Expand Up @@ -325,7 +325,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-2"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item-2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell data-list-cell--modifier="pf-m-icon"}}
Expand Down Expand Up @@ -353,7 +353,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-3" data-list-item--expanded="true"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item-3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell data-list-cell--modifier="pf-m-icon"}}
Expand Down Expand Up @@ -386,7 +386,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-1" data-list-item--expanded="true"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item-1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell data-list-cell--modifier="pf-m-icon"}}
Expand All @@ -411,7 +411,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item newcontext data-list--id=data-list--id data-list-item--id="item-1" data-list-item--expanded="true"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item-1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand All @@ -429,7 +429,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item newcontext data-list--id=data-list--id data-list-item--id="item-2"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item-2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand All @@ -447,7 +447,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item newcontext data-list--id=data-list--id data-list-item--expanded="true" data-list-item--id="item-3"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item-3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand All @@ -469,7 +469,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-2"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item-2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand All @@ -494,7 +494,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--expanded="true" data-list-item--id="item-3"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item-3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell data-list-cell--modifier="pf-m-icon"}}
Expand Down Expand Up @@ -693,7 +693,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-1" data-list-item--expanded="true"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item-1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{> data-list-check}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
Expand Down Expand Up @@ -794,7 +794,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-1" data-list-item--IsSelected="true" data-list-item--expanded="true"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle1 ' data-list--id '-item-1" id="' data-list--id '-toggle1" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content1"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand All @@ -812,7 +812,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-2"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle2 ' data-list--id '-item-2" id="' data-list--id '-toggle2" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content2"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand All @@ -830,7 +830,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-3" data-list-item--expanded="true"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle3 ' data-list--id '-item-3" id="' data-list--id '-toggle3" aria-label="Toggle details for" aria-expanded="true" aria-controls="' data-list--id '-content3"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand All @@ -848,7 +848,7 @@ When a list item includes more than one block of content, it can be difficult fo
{{#> data-list-item data-list-item--id="item-4"}}
{{#> data-list-item-row}}
{{#> data-list-item-control}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle4 ' data-list--id '-item4" id="' data-list--id '-toggle4" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content4"')}}{{/data-list-toggle}}
{{#> data-list-toggle button--attribute=(concat 'aria-labelledby="' data-list--id '-toggle4 ' data-list--id '-item-4" id="' data-list--id '-toggle4" aria-label="Toggle details for" aria-expanded="false" aria-controls="' data-list--id '-content4"')}}{{/data-list-toggle}}
{{/data-list-item-control}}
{{#> data-list-item-content}}
{{#> data-list-cell}}
Expand Down
Loading