Skip to content

fix(table): fix toggle vertical alignment #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 3 commits into from
Aug 5, 2025
Merged

fix(table): fix toggle vertical alignment #7722

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aded963
fix(table): fix toggle vertical alignment
mcoker Aug 4, 2025
3ba39e5
chore(table): fix lh for column help button
mcoker Aug 4, 2025
b716dce
chore(table): fix thead expand button min-width
mcoker Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/patternfly/components/Table/table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
--#{$table}__thead--cell--FontWeight: var(--pf-t--global--font--weight--body--bold);

// * Table thead toggle
--#{$table}__thead__toggle--PaddingBlockEnd: var(--pf-t--global--spacer--xs);
--#{$table}__thead__toggle--PaddingBlockStart: var(--#{$table}--cell--Padding--base); // TODO - remove thead toggle custom padding in breaking change
--#{$table}__thead__toggle--PaddingBlockEnd: var(--#{$table}--cell--Padding--base); // TODO - remove thead toggle custom padding in breaking change

// * Table body cell
--#{$table}__tbody--cell--PaddingBlockStart: var(--#{$table}--cell--Padding--base);
Expand Down Expand Up @@ -835,13 +836,20 @@
--#{$table}--cell--PaddingInlineStart: var(--#{$table}__toggle--PaddingInlineStart);
--#{$table}--cell--PaddingInlineEnd: var(--#{$table}__toggle--PaddingInlineEnd);

@at-root .#{$table}__thead & {
.#{$button} {
margin-block-start: calc(var(--#{$button}--PaddingBlockStart) * -1);
margin-block-end: calc(var(--#{$button}--PaddingBlockEnd) * -1);
line-height: 1lh; // set line-height instead of --LineHeight to avoid breaking the min-width calc for plain buttons
}
}

.#{$button} {
&.pf-m-expanded .#{$table}__toggle-icon {
transform: rotate(var(--#{$table}__toggle--c-button--m-expanded__toggle-icon--Rotate));
}
}


.#{$table}__toggle-icon {
@include pf-v6-mirror-inline-on-rtl;

Expand Down Expand Up @@ -997,6 +1005,10 @@
.#{$table}__column-help-action {
align-self: last baseline;
margin-inline-start: var(--#{$table}__column-help--MarginInlineStart);

.#{$button} {
line-height: 1lh; // set line-height instead of --LineHeight to avoid breaking the min-width calc for plain buttons
}
}

// - Table sort
Expand Down Expand Up @@ -1157,6 +1169,7 @@
// - Table thead
.#{$table}__thead {
--#{$table}__tr--BorderBlockEndWidth: 0;
--#{$table}__toggle--PaddingBlockStart: var(--#{$table}__thead__toggle--PaddingBlockStart);
--#{$table}__toggle--PaddingBlockEnd: var(--#{$table}__thead__toggle--PaddingBlockEnd);

vertical-align: bottom;
Expand Down