feat(DataList,Progress,Truncate): add tabindex - #7709
Merged
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7709.surge.sh A11y report: https://pf-pr-7709-a11y.surge.sh |
mcoker
approved these changes
Jul 31, 2025
thatblindgeye
left a comment
thatblindgeye
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Just a couple things:
- Tabindex verbiage for DataList can live in a11y docs when written. Would you mind opening a followup issue in org for Progress, though, to add the tabindex of 0 to the HTML/CSS table? Would be a quick update if you wanted to just put a PR up for it, but a followup issue wwould be fine for now.
- For Truncate, since these examples are a bit different to the other 2 components, can we just add some verbiage to the opening paragraph (below the "Examples" heading) about the tabindex? Basically just to let consumers know that the examples add a tabindex, but that it should only be applied when the text content is actually truncated. This would also live in a11y docs when written, but since we're hardcoding the tabindex without really a means to updat it, extra reminder won't hurt
kmcfaul
force-pushed
the
keyboard-focus-improvements
branch
from
August 12, 2025 18:38
2509e62 to
aba3b09
Compare
thatblindgeye
approved these changes
Aug 12, 2025
mcoker
requested changes
Aug 12, 2025
kmcfaul
force-pushed
the
keyboard-focus-improvements
branch
from
August 18, 2025 19:07
aba3b09 to
e2bb2ac
Compare
mcoker
requested changes
Sep 10, 2025
mcoker
left a comment
mcoker
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of spots where tabindex is showing up in the markup because it's rendering <element>tabindex="0"
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.65 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7270.