chore(descriptionList): add unique aria-labels to examples and demos - #7706
Conversation
Assisted-by: Cursor (used to generate aria-labels for all but 1 example based on title)
|
Preview: https://patternfly-pr-7706.surge.sh A11y report: https://patternfly-pr-7706-a11y.surge.sh |
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Just a couple o' comments, but what you have totally works, too!
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
There's some other files we'll also need to update where a DescriptionList is being used:
- the Card md demo file
- card-template-details handlebars
- card-template-events handlebars
- the Tabs md demo file
I think most of the aria-labels for the current files updates are fine, a nit might be some might be a bit lengthy, but that's sort of the nature of the example naming. I'd be fine with them as-is unless we could quickly tweak the naming - not a blocker, though.
c5522e8 to
929240b
Compare
929240b to
a12c2d5
Compare
|
Should be all set now @mcoker and @thatblindgeye! |
|
🎉 This PR is included in version 6.3.0-prerelease.48 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
Manually added ability to have aria-label. Manually added to demos and checked with VO. For examples, added 1 manually and checked with VO. Then tried using Cursor to generate additional aria-labels based on example title. Manually reviewed Cursor suggestions.
Assisted-by: Cursor (used to generate aria-labels for all but 1 example based on title)