Skip to content

chore(inline-edit/popover): remove stray code - #7675

Merged
mcoker merged 2 commits into
patternfly:mainfrom
mcoker:issue-7370
Jul 23, 2025
Merged

mcoker merged 2 commits into
patternfly:mainfrom
mcoker:issue-7370

Conversation

@mcoker

@mcoker mcoker commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

fixes #7370

@mcoker
mcoker requested a review from rebeccaalpert July 21, 2025 16:00
@patternfly-build

patternfly-build commented Jul 21, 2025 •

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still seeing a gray box between the two headers for inline edit, but it looks much better! Popover one is fixed.

Screenshot 2025-07-21 at 1 30 19 PM

@mcoker
mcoker requested a review from rebeccaalpert July 21, 2025 19:07
@mcoker

mcoker commented Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

@rebeccaalpert d'oh! I should have caught that. Would you mind looking again?

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@mcoker
mcoker merged commit a730dd0 into patternfly:main Jul 23, 2025
@mcoker
mcoker deleted the issue-7370 branch July 23, 2025 15:19
@patternfly-build

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.3.0-prerelease.42 🎉

The release is available on:

Your semantic-release bot 📦🚀

rebeccaalpert pushed a commit to rebeccaalpert/patternfly that referenced this pull request Jul 24, 2025
mcoker added a commit that referenced this pull request Jul 29, 2025
* chore(deps): update dependency @patternfly/documentation-framework to v6.15.5 (#7580)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @patternfly/react-code-editor to v6.3.0 (#7680)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(backstop): force light mode and fix no motion class (#7653)

* chore(all): update visual baseline images (#7610)

* chore(inline-edit/popover): remove stray code (#7675)

* fix(textinputgroup): update placeholder text color for disabled state (#7670)

* chore(deps): update dependency @patternfly/react-core to v6.3.0 (#7681)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @patternfly/react-table to v6.3.0 (#7682)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @patternfly/documentation-framework to v6.16.0 (#7684)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @patternfly/documentation-framework to v6.16.1 (#7689)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update upload-preview.js

* Update upload-preview.js

* fix: white space change to trigger prerelease

* Update README.md

* fix(wizard): nav item horizontal alignment fixes (#7693)

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Sarah Rambacher <[email protected]>
Co-authored-by: Evan <[email protected]>
Co-authored-by: Nicole Thoen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs - Popover - hbs is showing on component examples page

3 participants