Skip to content

TYP: fix positional- and keyword-only params in astype, cross and linalg #28348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charris merged 2 commits into from
Feb 17, 2025
Merged

TYP: fix positional- and keyword-only params in astype, cross and linalg #28348

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d561e
TYP: Fix missing typing arguments flags
Andrej730 Feb 13, 2025
a171335
TYP: Fix mismatching np.cross and np.linalg.cross typing arguments names
Andrej730 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
TYP: Fix mismatching np.cross and np.linalg.cross typing arguments names
  • Loading branch information
@Andrej730 @charris
Andrej730 authored and charris committed Feb 17, 2025
commit a1713351f152cbbe80ef3b886354af69f61d7049
28 changes: 14 additions & 14 deletions numpy/_core/numeric.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,62 +699,62 @@ def moveaxis(

@overload
def cross(
x1: _ArrayLikeUnknown,
x2: _ArrayLikeUnknown,
a: _ArrayLikeUnknown,
b: _ArrayLikeUnknown,
axisa: int = ...,
axisb: int = ...,
axisc: int = ...,
axis: None | int = ...,
) -> NDArray[Any]: ...
@overload
def cross(
x1: _ArrayLikeBool_co,
x2: _ArrayLikeBool_co,
a: _ArrayLikeBool_co,
b: _ArrayLikeBool_co,
axisa: int = ...,
axisb: int = ...,
axisc: int = ...,
axis: None | int = ...,
) -> NoReturn: ...
@overload
def cross(
x1: _ArrayLikeUInt_co,
x2: _ArrayLikeUInt_co,
a: _ArrayLikeUInt_co,
b: _ArrayLikeUInt_co,
axisa: int = ...,
axisb: int = ...,
axisc: int = ...,
axis: None | int = ...,
) -> NDArray[unsignedinteger[Any]]: ...
@overload
def cross(
x1: _ArrayLikeInt_co,
x2: _ArrayLikeInt_co,
a: _ArrayLikeInt_co,
b: _ArrayLikeInt_co,
axisa: int = ...,
axisb: int = ...,
axisc: int = ...,
axis: None | int = ...,
) -> NDArray[signedinteger[Any]]: ...
@overload
def cross(
x1: _ArrayLikeFloat_co,
x2: _ArrayLikeFloat_co,
a: _ArrayLikeFloat_co,
b: _ArrayLikeFloat_co,
axisa: int = ...,
axisb: int = ...,
axisc: int = ...,
axis: None | int = ...,
) -> NDArray[floating[Any]]: ...
@overload
def cross(
x1: _ArrayLikeComplex_co,
x2: _ArrayLikeComplex_co,
a: _ArrayLikeComplex_co,
b: _ArrayLikeComplex_co,
axisa: int = ...,
axisb: int = ...,
axisc: int = ...,
axis: None | int = ...,
) -> NDArray[complexfloating[Any, Any]]: ...
@overload
def cross(
x1: _ArrayLikeObject_co,
x2: _ArrayLikeObject_co,
a: _ArrayLikeObject_co,
b: _ArrayLikeObject_co,
axisa: int = ...,
axisb: int = ...,
axisc: int = ...,
Expand Down
16 changes: 8 additions & 8 deletions numpy/linalg/_linalg.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,32 +430,32 @@ def trace(

@overload
def cross(
a: _ArrayLikeUInt_co,
b: _ArrayLikeUInt_co,
x1: _ArrayLikeUInt_co,
x2: _ArrayLikeUInt_co,
/,
*,
axis: int = ...,
) -> NDArray[unsignedinteger[Any]]: ...
@overload
def cross(
a: _ArrayLikeInt_co,
b: _ArrayLikeInt_co,
x1: _ArrayLikeInt_co,
x2: _ArrayLikeInt_co,
/,
*,
axis: int = ...,
) -> NDArray[signedinteger[Any]]: ...
@overload
def cross(
a: _ArrayLikeFloat_co,
b: _ArrayLikeFloat_co,
x1: _ArrayLikeFloat_co,
x2: _ArrayLikeFloat_co,
/,
*,
axis: int = ...,
) -> NDArray[floating[Any]]: ...
@overload
def cross(
a: _ArrayLikeComplex_co,
b: _ArrayLikeComplex_co,
x1: _ArrayLikeComplex_co,
x2: _ArrayLikeComplex_co,
/,
*,
axis: int = ...,
Expand Down