Require binary format in binary importer - #5648
Merged
Merged
Conversation
NinoFloris
force-pushed
the
require-binary-format
branch
2 times, most recently
from
March 27, 2024 15:39
43ab9c9 to
f4da7d8
Compare
roji
approved these changes
Mar 28, 2024
NinoFloris
force-pushed
the
require-binary-format
branch
from
March 28, 2024 18:20
f4da7d8 to
7100049
Compare
NinoFloris
added a commit
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit f320515)
Member
Author
|
Backported to 8.0.3 via 07a0702 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something I came across while working on better text format support.
We have format preference logic already, we just need to validate at the end we got what we 'require'.
Cleaned up that code a bit, much easier to read now.