Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
juanarbol
force-pushed
the
v22.x-staging
branch
from
August 20, 2026 19:41
e21045e to
7bd96e3
Compare
juanarbol
force-pushed
the
ja/backport-v8
branch
from
August 21, 2026 15:53
60b6f0b to
b29c3b8
Compare
richardlau
approved these changes
Aug 21, 2026
juanarbol
added
request-ci
Collaborator
juanarbol
force-pushed
the
v22.x-staging
branch
from
August 21, 2026 17:53
6543035 to
7c2df5d
Compare
Original commit message:
[logging] Use RecursiveMutex for Logger
Logger::allows_code_compaction might be called from within a
CodeCreateEvent where initializing line script line ends might trigger
a GC. During compaction we check if code compaction is allowed which
calls back into the above Logger method.
Bug: 41497149
Change-Id: Ifd1b740df8600584780341d8214e995832e663b4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5572952
Reviewed-by: Victor Gomes <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94140}
Refs: v8/v8@a6eaf75
juanarbol
force-pushed
the
ja/backport-v8
branch
from
August 21, 2026 18:00
b29c3b8 to
5b75ee6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
juanarbol
pushed a commit
that referenced
this pull request
Aug 26, 2026
Original commit message:
[logging] Use RecursiveMutex for Logger
Logger::allows_code_compaction might be called from within a
CodeCreateEvent where initializing line script line ends might trigger
a GC. During compaction we check if code compaction is allowed which
calls back into the above Logger method.
Bug: 41497149
Change-Id: Ifd1b740df8600584780341d8214e995832e663b4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5572952
Reviewed-by: Victor Gomes <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94140}
Refs: v8/v8@a6eaf75
PR-URL: #65402
Fixes: #65140
Reviewed-By: Richard Lau <[email protected]>
Member
Author
|
Landed in 3376e27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@a6eaf75
Fixes: #65140