Conversation
Signed-off-by: Filip Skokan <[email protected]>
panva
added
the
fast-track
Collaborator
|
Review requested:
|
Contributor
|
Fast-track has been requested by @panva. Please 👍 to approve. |
nodejs-github-bot
added
the
meta
aduh95
approved these changes
Aug 8, 2026
| ncu-config set jenkins_token "$JENKINS_TOKEN" | ||
| ncu-config set repo "${REPOSITORY}" | ||
| ncu-config set owner "${GITHUB_REPOSITORY_OWNER}" | ||
| # Keep the config outside the workspace so checkout does not remove it. |
Contributor
There was a problem hiding this comment.
nit: I'd put the comment in the YAML rather than the bash (I guess it's irrelevant here, but it's quite important in Nix files to avoid invalidating a build when fixing a typo in a comment)
avivkeller
approved these changes
Aug 8, 2026
panva
added a commit
that referenced
this pull request
Aug 8, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #65132 Refs: #64343 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Aviv Keller <[email protected]>
Member
Author
|
Landed in b65015a |
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #65132 Refs: #64343 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Aviv Keller <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #65132 Refs: #64343 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Aviv Keller <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Aug 27, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #65132 Refs: #64343 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Aviv Keller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we checkout after we set the credentials now the checkout overwrites the local ncu config, switch it to global for this job.
Refs: #64343
Refs: #64991 (comment)