src: drop localhost6 as allowed host for inspector

mcollina · richardlau · commit 1564752d553f · 2021-02-22T17:12:37.000Z
CVE-ID: CVE-2021-22884 Refs: https://hackerone.com/bugs?report_id=1069487 PR-URL: nodejs-private/node-private#244 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/src/inspector_socket.cc b/src/inspector_socket.cc
@@ -584,8 +584,7 @@ class HttpHandler : public ProtocolHandler {
   bool IsAllowedHost(const std::string& host_with_port) const {
     std::string host = TrimPort(host_with_port);
     return host.empty() || IsIPAddress(host)
-           || node::StringEqualNoCase(host.data(), "localhost")
-           || node::StringEqualNoCase(host.data(), "localhost6");
+           || node::StringEqualNoCase(host.data(), "localhost");
   }
 
   bool parsing_value_;

Original file line number	Diff line number	Diff line change
`@@ -584,8 +584,7 @@ class HttpHandler : public ProtocolHandler {`
`584`	`584`	`bool IsAllowedHost(const std::string& host_with_port) const {`
`585`	`585`	`std::string host = TrimPort(host_with_port);`
`586`	`586`	`return host.empty() \|\| IsIPAddress(host)`
`587`		`- \|\| node::StringEqualNoCase(host.data(), "localhost")`
`588`		`- \|\| node::StringEqualNoCase(host.data(), "localhost6");`
	`587`	`+ \|\| node::StringEqualNoCase(host.data(), "localhost");`
`589`	`588`	`}`
`590`	`589`
`591`	`590`	`bool parsing_value_;`