Skip to content

npm install --production#11

Closed
refractalize wants to merge 3 commits into
nodejs:masterfrom
featurist:master
Closed

npm install --production#11
refractalize wants to merge 3 commits into
nodejs:masterfrom
featurist:master

Conversation

@refractalize

Copy link
Copy Markdown

Was there a reason not to use npm install --production in the onbuild Dockerfiles?

I found my docker build downloading all my dev dependencies and wondered...

Cheers

@md5

md5 commented Feb 12, 2015

Copy link
Copy Markdown

See #3 for previous discussion

@md5

md5 commented Feb 12, 2015

Copy link
Copy Markdown

Also, docker-library/node#14

@eexit

eexit commented Nov 4, 2015

Copy link
Copy Markdown

I don't agree with that: if you need production dependencies, just add the NODE_ENV=production env variable. In my use case, I build the container into the CI and only the succeed container will go into production, we use the same container to ensure the reliability of the deployed code.

@Starefossen

Copy link
Copy Markdown
Member

I am closing this since we want the onbuild variant to be as general purpose as possible and there exists ways to force production packages only gets installed.

@chorrell

Copy link
Copy Markdown
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants