feat(bigtable): add accelerator daemon subprocess wrapper - #1
Open
mutianf wants to merge 5 commits into
Open
Conversation
Change-Id: I10d1659a0299349c0bf197d4135a2589b6fa7a41
mutianf
force-pushed
the
accel-01-daemon-subprocess-wrapper
branch
from
August 11, 2026 14:07
31c2eff to
1d562a6
Compare
mutianf
commented
Aug 11, 2026
…e instead of PIPE Change-Id: Id859a0b2006237ad7343ee473d768b4b7119f0e8
…so it is cleaned up Change-Id: I9fcce911c5b2a2fa1232859f816e77a993f57735
daniel-sanche
left a comment
daniel-sanche
left a comment
There was a problem hiding this comment.
Overall looks good, but let some suggestions
| _BIN_ENV_VAR = "BIGTABLE_ACCELERATOR_BIN" | ||
|
|
||
| # Wheels ship the binary at this path relative to the `_accelerator/` package. | ||
| _DEFAULT_BIN_RELATIVE_PATH = "bin/accelerator" |
There was a problem hiding this comment.
nit: do we need to store the relative path separately, or should we just store the full path here?
_DEFAULT_BIN_PATH = Path(__file__).parent / "bin" / "accelerator"
Owner
Author
There was a problem hiding this comment.
inlined inside of _resolve_binary_path now
Change-Id: Ia9d16d2d7d78a48076cfa0cb9809dc61e4f645ea
Change-Id: I3346fce33de1069f27e08e78691c104a169c886b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack PR 1/7 — base:
acceleratorAdds the
AcceleratorDaemonsubprocess wrapper that spawns the Go accelerator binary on a Unix domain socket, mints a per-daemon stdin handshake secret, waits for the UDS to become connectable, and manages teardown.Accelerator stack