Skip to content

Deprecation time #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 1 commit into from
Dec 8, 2024
Merged

Deprecation time #3768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/main/java/graphql/execution/DataFetcherResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,6 @@ public class DataFetcherResult<T> {
private final Object localContext;
private final Map<Object, Object> extensions;

/**
* Creates a data fetcher result
*
* @param data the data
* @param errors the errors
*
* @deprecated use the {@link #newResult()} builder instead
*/
@Internal
@Deprecated(since = "2019-01-11")
public DataFetcherResult(T data, List<GraphQLError> errors) {
this(data, errors, null, null);
}

Copy link
Copy Markdown
Member

@bbakerman bbakerman Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

private DataFetcherResult(T data, List<GraphQLError> errors, Object localContext, Map<Object, Object> extensions) {
this.data = data;
this.errors = ImmutableList.copyOf(assertNotNull(errors));
Expand Down
11 changes: 0 additions & 11 deletions src/main/java/graphql/execution/ExecutionStepInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,6 @@ private ExecutionStepInfo(Builder builder) {
this.fieldContainer = builder.fieldContainer;
}

/**
* @return the GraphQLObjectType defining the {@link #getFieldDefinition()}
*
* @see ExecutionStepInfo#getObjectType()
* @deprecated use {@link #getObjectType()} instead as it is named better
*/
@Deprecated(since = "2022-02-03")
public GraphQLObjectType getFieldContainer() {
return fieldContainer;
}

Copy link
Copy Markdown
Member

@bbakerman bbakerman Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

/**
* The GraphQLObjectType where fieldDefinition is defined.
* Note:
Expand Down
11 changes: 0 additions & 11 deletions src/main/java/graphql/execution/FieldValueInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,6 @@ public CompletableFuture<Object> getFieldValueFuture() {
return Async.toCompletableFuture(fieldValueObject);
}

/**
* Kept for legacy reasons - this method is no longer sensible and is no longer used by the graphql-java engine
* and is kept only for backwards compatible API reasons.
*
* @return a promise to the {@link ExecutionResult} that wraps the field value.
*/
@Deprecated(since = "2023-09-11")
public CompletableFuture<ExecutionResult> getFieldValue() {
return getFieldValueFuture().thenApply(fv -> ExecutionResultImpl.newExecutionResult().data(fv).build());
}
Copy link
Copy Markdown
Member

@bbakerman bbakerman Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup


/**
* @return true if the value is a {@link CompletableFuture} promise to a value
*/
Expand Down