Skip to content

Added some more tests around providing default values #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 5 commits into from
Nov 7, 2024
Merged

Added some more tests around providing default values #3709

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
adb00f0
Added some more tests around providing default values
bbakerman Sep 21, 2024
e359053
Comments describing each case
bbakerman Sep 21, 2024
812c0bb
Update src/test/groovy/graphql/DefaultValuesTest.groovy
dondonz Nov 7, 2024
6da9730
Update src/test/groovy/graphql/DefaultValuesTest.groovy
dondonz Nov 7, 2024
beef012
Update src/test/groovy/graphql/DefaultValuesTest.groovy
dondonz Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 116 additions & 0 deletions src/test/groovy/graphql/DefaultValuesTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
package graphql

import graphql.schema.DataFetcher
import spock.lang.Specification

import static graphql.ExecutionInput.newExecutionInput

class DefaultValuesTest extends Specification {

def "provided values override defaults"() {
def sdl = """
type Query {
myField(deleted: Boolean = true) : String
myField2(deleted: Boolean = true) : String
}
"""

def df = { env ->
return "dataFetcherArg=" + env.getArgument("deleted")
} as DataFetcher
def graphQL = TestUtil.graphQL(sdl, [Query: [
myField : df,
myField2: df]]
).build()

//
// The variable is present in the variables map and its explicitly null
//
// https://spec.graphql.org/draft/#sec-Coercing-Variable-Values
//
when:
def ei = newExecutionInput('''
query myQuery($deleted: Boolean = false) {
myField(deleted : $deleted)
}
''').variables(["deleted": null]).build()
def er = graphQL.execute(ei)

then:
er.errors.isEmpty()
er.data == [myField: "dataFetcherArg=null"]

//
// The variable is present in the variables map and its explicitly a value
//
// https://spec.graphql.org/draft/#sec-Coercing-Variable-Values
//
when:
ei = newExecutionInput('''
query myQuery($deleted: Boolean = false) {
myField(deleted : $deleted)
}
''').variables(["deleted": true]).build()
er = graphQL.execute(ei)

then:
er.errors.isEmpty()
er.data == [myField: "dataFetcherArg=true"]

//
// The variable is NOT present in the variables map it should use a default
// value from the variable declaration
//
// https://spec.graphql.org/draft/#sec-Coercing-Variable-Values
//
when:
ei = newExecutionInput('''
query myQuery($deleted: Boolean = false) {
myField(deleted : $deleted)
}
''').variables(["NotProvided": "valueNotProvided"]).build()
er = graphQL.execute(ei)

then:
er.errors.isEmpty()
er.data == [myField: "dataFetcherArg=false"]

//
// The variable is NOT present in the variables map and a variable is NOT used
// it should use a default value from the field declaration
//
//
when:
ei = newExecutionInput('''
query myQuery($deleted: Boolean = false) {
myField
myField2(deleted : $deleted)
}
''').variables(["NotProvided": "valueNotProvided"]).build()
er = graphQL.execute(ei)

then:
er.errors.isEmpty()
er.data == [myField : "dataFetcherArg=true",
myField2: "dataFetcherArg=false"]

//
// If there are no variables on the query operation
// it should use a default value from the field declaration
// or literals provided
//
when:
ei = newExecutionInput('''
query myQuery {
myField(deleted :false)
myField2
}
''').variables(["NotProvided": "valueNotProvided"]).build()
er = graphQL.execute(ei)

then:
er.errors.isEmpty()
er.data == [myField : "dataFetcherArg=false",
myField2: "dataFetcherArg=true"]
}
}