Skip to content

Commit a0d6ca6

Browse files
spark404spark404
committed
Make variable naming consistent with the superclass.
The field was called brandnew in portforwaringto and alreadyadded in firewallruleto. This leads to confusion as the effect is completely opposite. Small fix for wrong parameter order
1 parent 48308ec commit a0d6ca6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎api/src/com/cloud/agent/api/to/PortForwardingRuleTO.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ public PortForwardingRuleTO(PortForwardingRule rule, String srcVlanTag, String s
3939
this.dstPortRange = new int[] { rule.getDestinationPortStart(), rule.getDestinationPortEnd() };
4040
}
4141

42-
protected PortForwardingRuleTO(long id, String srcIp, int srcPortStart, int srcPortEnd, String dstIp, int dstPortStart, int dstPortEnd, String protocol, boolean revoked, boolean brandNew) {
43-
super(id, srcIp,null, protocol, srcPortStart, srcPortEnd, revoked, brandNew, FirewallRule.Purpose.PortForwarding, null,0,0);
42+
public PortForwardingRuleTO(long id, String srcIp, int srcPortStart, int srcPortEnd, String dstIp, int dstPortStart, int dstPortEnd, String protocol, boolean revoked, boolean alreadyAdded) {
43+
super(id, null, srcIp, protocol, srcPortStart, srcPortEnd, revoked, alreadyAdded, FirewallRule.Purpose.PortForwarding, null,0,0);
4444
this.dstIp = dstIp;
4545
this.dstPortRange = new int[] { dstPortStart, dstPortEnd };
4646
}

0 commit comments

Comments
 (0)