Repository navigation
Add tracing to DramatiqIntegration #3454
Description
How do you use Sentry?
Self-hosted/on-premise
Version
2.13.0
Steps to Reproduce
- Follow the instructions on https://docs.sentry.io/platforms/python/integrations/dramatiq/ for using the
DramatiqIntegration - Enable tracing and profiling
Additional context:
I know #3397 was recently released and this is most likely happening because that integration is only capturing events from exceptions, but the documentation still states that it is just a matter of enabling tracing or profiling.
Would be amazing to have tasks instrumented automatically, but maybe a temporary warning in the dramatiq integration docs to make it explicit that it doesn't work without manual instrumentation.
Expected Result
Dramatiq actors tracing and profiling appear in performance and profiling sections of Sentry without manual instrumentation
Actual Result
Dramatiq actors tracing and profiling do not appear in performance and profiling sections of Sentry
Metadata
Metadata
Assignees
Labels
Projects
- Status
Activity
[-]dramatiq integration with no tracing or profiling[/-][+]Add tracing to `DramatiqIntegration`[/+]szokeasaurusrex commentedon Aug 26, 2024
Hi @ramonsaraiva, it indeed appears that the
DramatiqIntegrationdoes not support tracing/profiling; the docs page is incorrect.I opened a separate issue to make sure we update our docs page.
Additionally, I renamed this issue to "Add tracing to
DramatiqIntegration" and will place it on our backlog. We are busy with larger projects at the moment, so it might take us some time to get around to adding tracing to the Dramatiq integration. If you (or anyone else from the community) would like, please feel free to contribute a PR to add this functionality. We are happy to help with reviews.wsantos commentedon Sep 3, 2024
@szokeasaurusrex Is there a guideline or docs explaining how this could be implemented, I am happy to give it a shot.
szokeasaurusrex commentedon Sep 4, 2024
Hey @wsantos, the separate issue that you are referencing was the issue to update our docs to state that
Dramaticdoes not support tracing, and I have already completed this.Are you instead wondering about how to add tracing to Dramatiq, which would solve this issue? If so, we have some SDK Development Docs, but I don't think these cover how to write a tracing integration (perhaps this is something we can add). My recommendation is to take a look at the source code for other integrations which do have tracing and base your implementation on that. You can feel free to reach out to us if you get stuck anywhere
15 remaining items
feat(integrations): Add trace propagation to DramatiqIntegration
feat(integration): Fix dramatiq py3.6 and linters issues (getsentry#3454
feat(integrations): Start new trace on retrying
feat(integrations): Remove ContextVar usage.
feat(integrations): Isolation scope
feat(integrations): Fix scope usage
feat(integrations): Add tracing to DramatiqIntegration (#4571)