Skip to content

Commit 45a92ba

Browse files
committed
Fix the initialization of management server
1 parent 0f5c5c2 commit 45a92ba

4 files changed

Lines changed: 14 additions & 20 deletions

File tree

‎engine/storage/src/org/apache/cloudstack/storage/datastore/provider/DataStoreProviderManagerImpl.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public List<DataStoreProvider> getDataStoreProviders() {
5858
public boolean configure(String name, Map<String, Object> params)
5959
throws ConfigurationException {
6060

61-
61+
/*
6262
//TODO: hold global lock
6363
List<DataStoreProviderVO> providerVos = providerDao.listAll();
6464
for (DataStoreProvider provider : providers) {
@@ -86,7 +86,7 @@ public boolean configure(String name, Map<String, Object> params)
8686
provider.configure(params);
8787
providerMap.put(uuid, provider);
8888
}
89-
89+
*/
9090
return true;
9191
}
9292

‎plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,7 @@ protected boolean canHandle(Network network, Service service) {
206206
public boolean configure(String name, Map<String, Object> params)
207207
throws ConfigurationException {
208208
super.configure(name, params);
209-
_resourceMgr.registerResourceStateAdapter(this.getClass()
210-
.getSimpleName(), this);
209+
_resourceMgr.registerResourceStateAdapter(name, this);
211210
return true;
212211
}
213212

‎server/src/com/cloud/hypervisor/kvm/discoverer/KvmServerDiscoverer.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,4 @@ public boolean stop() {
392392
_resourceMgr.unregisterResourceStateAdapter(this.getClass().getSimpleName());
393393
return super.stop();
394394
}
395-
396-
397395
}

‎utils/src/com/cloud/utils/component/ComponentContext.java‎

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,11 @@
1818
package com.cloud.utils.component;
1919

2020
import java.util.ArrayList;
21-
import java.util.Collection;
2221
import java.util.HashMap;
2322
import java.util.List;
2423
import java.util.Map;
2524

26-
import javax.annotation.PostConstruct;
25+
import javax.inject.Inject;
2726
import javax.naming.ConfigurationException;
2827

2928
import org.apache.log4j.Logger;
@@ -51,24 +50,22 @@
5150
public class ComponentContext implements ApplicationContextAware {
5251
private static final Logger s_logger = Logger.getLogger(ComponentContext.class);
5352

54-
private static ApplicationContext s_appContext;
53+
private static ApplicationContext s_appContext;
5554

55+
@Inject List<GenericDao> daos;
56+
@Inject List<Manager> mgrs;
57+
@Inject List<Adapter> adapters;
58+
5659
@Override
5760
public void setApplicationContext(ApplicationContext applicationContext) {
58-
s_appContext = applicationContext;
61+
s_appContext = applicationContext;
5962
}
6063

6164
public static ApplicationContext getApplicationContext() {
6265
return s_appContext;
63-
}
64-
65-
@PostConstruct
66-
public void initComponentsLifeCycle() {
67-
@SuppressWarnings("rawtype")
68-
Collection<GenericDao> daos = ComponentContext.getApplicationContext().getBeansOfType(GenericDao.class).values();
69-
Collection<Manager> mgrs = ComponentContext.getApplicationContext().getBeansOfType(Manager.class).values();
70-
Collection<Adapter> adapters = ComponentContext.getApplicationContext().getBeansOfType(Adapter.class).values();
71-
66+
}
67+
68+
public void init() {
7269
Map<String, Object> params = new HashMap<String, Object>();
7370
for (GenericDao dao : daos) {
7471
try {
@@ -80,7 +77,7 @@ public void initComponentsLifeCycle() {
8077
}
8178
}
8279

83-
List<String> avoidMap = new ArrayList<String>();
80+
List<String> avoidMap = new ArrayList<String>();
8481
for (Manager manager : mgrs) {
8582
if (avoidMap.contains(manager.getName())) {
8683
s_logger.info("Skip manager: " + ComponentContext.getTargetClass(manager).getName() + " as it is already started");

0 commit comments

Comments
 (0)