Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: datrs/hypercore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: datrs/hypercore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: async-trait
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 21 files changed
  • 1 contributor

Commits on Mar 3, 2020

  1. Move from failure to use stderr 

    Related to #101
    @bltavares
    bltavares committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    5c6a73e View commit details
    Browse the repository at this point in the history

  2. Implement async API for random-access-storage 

    This commit moves the API from a sync call into async functions using async_trait.

We would like to use async operations on hypercore, and it would be nice to have the underlying storage using async-io when possible.
As discussed on #97, we could change the API to use async functions on the 'ram' trait.

Async Trait methods are still unstable, but possible using the 'async-trait' crate through a macro.

This PR moves the API to use async-fns. Tests are passing.
    @bltavares
    bltavares committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    f41ebe3 View commit details
    Browse the repository at this point in the history
Loading