refs #14498 - do not create static instances of the checks#8555
Draft
firewave wants to merge 1 commit into
Draft
refs #14498 - do not create static instances of the checks#8555firewave wants to merge 1 commit into
firewave wants to merge 1 commit into
Conversation
Collaborator
Author
|
Since we switched to non- As a follow-up we can stop relying on the global check instances in the tests and use local ones instead. As a final step this will (hopefully) finally allow us to land #5323. |
firewave
commented
May 13, 2026
| Check& operator=(const Check &) = delete; | ||
|
|
||
| /** List of registered check classes. This is used by Cppcheck to run checks and generate documentation */ | ||
| static std::list<Check *> &instances(); |
Collaborator
Author
There was a problem hiding this comment.
As another positive side effect this no longer needs to return a mutable reference.
firewave
commented
May 13, 2026
|
|
||
| private: | ||
| void run() override { | ||
| TEST_CASE(instancesSorted); |
Collaborator
Author
There was a problem hiding this comment.
As we now have a fixed order of the checks there no longer is any reason to sort them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.