Skip to content

Add CI check for API since annotation version on branches >= 24 - #14196

Draft
Pearl1594 wants to merge 1 commit into
mainfrom
ci-param-cs-version
Draft

Pearl1594 wants to merge 1 commit into
mainfrom
ci-param-cs-version

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR addresses: #14041 (comment)

It checks the following:

  • a new field, with since = "4.24" - Flagged
  • a new field, with since = "24.0" - Pass
  • a new field, no since - Flagged
  • editing description on an existing field that never had since - No op
  • brand-new @APICommand class with no since - Flagged
  • editing an existing @APICommand's description - No op

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg Bot added component:integration Python Warning... Python code Ahead! labels Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.91%. Comparing base (27722a5) to head (bd9d98b).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #14196   +/-   ##
=========================================
  Coverage     19.91%   19.91%           
- Complexity    20175    20178    +3     
=========================================
  Files          6372     6372           
  Lines        577139   577180   +41     
  Branches      70682    70693   +11     
=========================================
+ Hits         114913   114930   +17     
- Misses       449664   449685   +21     
- Partials      12562    12565    +3     
Flag Coverage Δ
uitests 3.71% <ø> (ø)
unittests 21.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594
Pearl1594 requested a review from shwstppr September 17, 2026 19:22
@Pearl1594 Pearl1594 added this to the 24.0 milestone Sep 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.83%
Branch coverage 19.03%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:integration Python Warning... Python code Ahead!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant