Fix for NFS primary storage pool failing to come out of maintenance mode - #14187
Open
sandeeplocharla wants to merge 1 commit into
Open
sandeeplocharla wants to merge 1 commit into
sandeeplocharla wants to merge 1 commit into
Conversation
Enable maintenance on KVM NFS goes through deleteStoragePool(uuid, details), which LibvirtStorageAdaptor did not override, so the default no-op ran after the HA monitor unmounted the share. Cancel maintenance then reused a defined libvirt pool with no mount. Override the details delete path to destroy the libvirt pool, and unmount via the HA monitor only after libvirt has deleted the pool. Fixes: apache#12690 Signed-off-by: sandeeplocharla <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable maintenance on KVM NFS goes through deleteStoragePool(uuid, details), which LibvirtStorageAdaptor did not override, so the default no-op ran after the HA monitor unmounted the share. Cancel maintenance then reused a defined libvirt pool with no mount.
Override the details delete path to destroy the libvirt pool, and unmount via the HA monitor only after libvirt has deleted the pool.
Fixes: #12690
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?