Skip to content

Configuration keys performance update - #14173

Draft
sb-abhish3k wants to merge 1 commit into
apache:4.22from
shapeblue:improve-configkey-performance
Draft

sb-abhish3k wants to merge 1 commit into
apache:4.22from
shapeblue:improve-configkey-performance

Conversation

@sb-abhish3k

Copy link
Copy Markdown

Description

Configuration keys: cache inherited parent-scope value on scope miss to avoid repeated DB lookups.
Implemented caching inherited parent-scope value under "current" scope to avoid repeated configuration key hierarchy traversal

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sb-abhish3k

Copy link
Copy Markdown
Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@sb-abhish3k a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.95%. Comparing base (10037c8) to head (7b0b037).

Files with missing lines Patch % Lines
...udstack/framework/config/impl/ConfigDepotImpl.java 68.00% 12 Missing and 4 partials ⚠️
...ack/framework/config/dao/ConfigurationDaoImpl.java 0.00% 4 Missing ⚠️
.../apache/cloudstack/framework/config/ConfigKey.java 75.00% 0 Missing and 1 partial ⚠️
...a/org/apache/cloudstack/utils/cache/LazyCache.java 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #14173      +/-   ##
============================================
+ Coverage     17.93%   17.95%   +0.01%     
- Complexity    16142    16161      +19     
============================================
  Files          5928     5928              
  Lines        535205   535265      +60     
  Branches      65501    65507       +6     
============================================
+ Hits          95989    96084      +95     
+ Misses       428286   428249      -37     
- Partials      10930    10932       +2     
Flag Coverage Δ
uitests 4.02% <ø> (ø)
unittests 19.02% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19249

Configuration keys: cache inherited parent-scope value on scope miss to avoid repeated DB lookups.
Implemented caching inherited parent-scope value under "current" scope to avoid repeated configuration key hierarchy traversal.
@sb-abhish3k
sb-abhish3k force-pushed the improve-configkey-performance branch from 7333cbd to 7b0b037 Compare September 16, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants