Conversation
angular-robot
Bot
added
detected: feature
atscott
force-pushed
the
destroyRefDestroyed
branch
from
June 3, 2025 18:24
c024f45 to
2f893dc
Compare
Since `DestroyRef.onDestroy` throws if the `DestroyRef` is already destroyed, there is a need to be able to tell if it is already destroyed before attempting to register a callback.
atscott
force-pushed
the
destroyRefDestroyed
branch
from
June 4, 2025 17:24
2f893dc to
32fc7ee
Compare
atscott
marked this pull request as ready for review
June 4, 2025 17:24
thePunderWoman
approved these changes
Jun 4, 2025
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
thePunderWoman
removed request for
AndrewKushnir,
mmalerba and
pkozlowski-opensource
June 4, 2025 17:27
Contributor
|
This PR was merged into the repository by commit 8163a89. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
DestroyRef.onDestroythrows if theDestroyRefis alreadydestroyed, there is a need to be able to tell if it is already destroyed
before attempting to register a callback.
(first commit is in #61847)